API, Core: Fix naming in fastForwardBranch/replaceBranch APIs #9134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @rakesh-das08 @singhpk234 This stems from our discussion on #8854 (comment) |
amogh-jahagirdar
force-pushed
the
rename-source-target-ffapi
branch
9 times, most recently
from
d33430d to
08e41ce
Compare
nastra
reviewed
Nov 23, 2023
nastra
reviewed
Nov 23, 2023
core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
rename-source-target-ffapi
branch
from
08e41ce to
f8a7c24
Compare
nastra
reviewed
Nov 27, 2023
| Preconditions.checkArgument(sourceRef != null, "Ref does not exist: %s", source); | ||
| Preconditions.checkArgument(refToUpdate.isBranch(), "Ref %s is a tag not a branch", name); | ||
| String from, String to, boolean fastForward) { | ||
| Preconditions.checkNotNull(from, "Branch to update cannot be null"); |
Contributor
There was a problem hiding this comment.
I think we're a little inconsistent here in terms of null checking (throwing NPE vs IAE) but I guess that's out-of-scope for this PR, so just wanted to mention that
Contributor
Author
There was a problem hiding this comment.
Yeah you're right, and this unfortunately applies to more than just replace/fastForward. (e.g. create, rename, as well throw an NPE instead of IAE). I'll take this in a follow on.
nastra
approved these changes
Nov 27, 2023
Contributor
Author
|
Merging, thanks for the reviews @nastra @rakesh-das08 |
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes some very confusing naming from my original implementation of the fastForward/replaceBranch APIs.
Prior to this change, the APIs had the following naming:
"Name" is the branch that would be fast forwarded and source is the "destination" or target we would fast forward to. This doesn't really align with how most people would think when it comes to fast forward or replace operations (like Git).
This change renames it to:
Note: This is just a rename of parameters and error messages. There is no change in behavior in the API.